Question on problems with compile/make on OSX 10.7.5
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Question on problems with compile/make on OSX 10.7.5
I have OSX Lion 10.7.5 and the latest Xcode 4.5.2. I have downloaded the recent X11 application update from Apple -http://support.apple.com/kb/DL1605.
I have downloaded and extracted the the Wine 1.4.1 source from ibiblio. I am following the 'build with minimal fuss' instructions on the WineHQ wiki - http://wiki.winehq.org/MacOSX/Building# ... 33c9078c20
I ran the configure:
./configure --verbose --x-includes=/usr/X11/include --x-libraries=/usr/X11/lib
It finished and I ran make. The make failed. Last 4 lines are:
collect2: ld returned 1 exit status
winegcc: gcc failed
make[1]: *** [openal32.dll.so] Error 2
make: *** [dlls/openal32] Error 2
Grateful for any assistance or pointers.
I have downloaded and extracted the the Wine 1.4.1 source from ibiblio. I am following the 'build with minimal fuss' instructions on the WineHQ wiki - http://wiki.winehq.org/MacOSX/Building# ... 33c9078c20
I ran the configure:
./configure --verbose --x-includes=/usr/X11/include --x-libraries=/usr/X11/lib
It finished and I ran make. The make failed. Last 4 lines are:
collect2: ld returned 1 exit status
winegcc: gcc failed
make[1]: *** [openal32.dll.so] Error 2
make: *** [dlls/openal32] Error 2
Grateful for any assistance or pointers.
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Here's the last part of the make output in full...
Code: Select all
ld: warning: ignoring file /Library/Frameworks//OpenAL.framework/OpenAL, file was built for unsupported file format ( 0xfe 0xed 0xfa 0xce 0x 0 0x 0 0x 0 0x12 0x 0 0x 0 0x 0 0x 0 0x 0 0x 0 0x 0 0x 6 ) which is not the architecture being linked (i386): /Library/Frameworks//OpenAL.framework/OpenAL
Undefined symbols for architecture i386:
"_alBuffer3f", referenced from:
_wine_alBuffer3f in openal.o
(maybe you meant: _wine_alBuffer3f)
"_alBuffer3i", referenced from:
_wine_alBuffer3i in openal.o
(maybe you meant: _wine_alBuffer3i)
"_alBufferData", referenced from:
_wine_alBufferData in openal.o
(maybe you meant: _wine_alBufferData)
"_alBufferf", referenced from:
_wine_alBufferf in openal.o
(maybe you meant: _wine_alBufferf, _wine_alBufferfv )
"_alBufferfv", referenced from:
_wine_alBufferfv in openal.o
(maybe you meant: _wine_alBufferfv)
"_alBufferi", referenced from:
_wine_alBufferi in openal.o
(maybe you meant: _wine_alBufferi, _wine_alBufferiv )
"_alBufferiv", referenced from:
_wine_alBufferiv in openal.o
(maybe you meant: _wine_alBufferiv)
"_alDeleteBuffers", referenced from:
_wine_alDeleteBuffers in openal.o
(maybe you meant: _wine_alDeleteBuffers)
"_alDeleteSources", referenced from:
_wine_alDeleteSources in openal.o
(maybe you meant: _wine_alDeleteSources)
"_alDisable", referenced from:
_wine_alDisable in openal.o
(maybe you meant: _wine_alDisable)
"_alDistanceModel", referenced from:
_wine_alDistanceModel in openal.o
(maybe you meant: _wine_alDistanceModel)
"_alDopplerFactor", referenced from:
_wine_alDopplerFactor in openal.o
(maybe you meant: _wine_alDopplerFactor)
"_alDopplerVelocity", referenced from:
_wine_alDopplerVelocity in openal.o
(maybe you meant: _wine_alDopplerVelocity)
"_alEnable", referenced from:
_wine_alEnable in openal.o
(maybe you meant: _wine_alEnable)
"_alGenBuffers", referenced from:
_wine_alGenBuffers in openal.o
(maybe you meant: _wine_alGenBuffers)
"_alGenSources", referenced from:
_wine_alGenSources in openal.o
(maybe you meant: _wine_alGenSources)
"_alGetBoolean", referenced from:
_wine_alGetBoolean in openal.o
(maybe you meant: _wine_alGetBoolean, _wine_alGetBooleanv )
"_alGetBooleanv", referenced from:
_wine_alGetBooleanv in openal.o
(maybe you meant: _wine_alGetBooleanv)
"_alGetBuffer3f", referenced from:
_wine_alGetBuffer3f in openal.o
(maybe you meant: _wine_alGetBuffer3f)
"_alGetBuffer3i", referenced from:
_wine_alGetBuffer3i in openal.o
(maybe you meant: _wine_alGetBuffer3i)
"_alGetBufferf", referenced from:
_wine_alGetBufferf in openal.o
(maybe you meant: _wine_alGetBufferf, _wine_alGetBufferfv )
"_alGetBufferfv", referenced from:
_wine_alGetBufferfv in openal.o
(maybe you meant: _wine_alGetBufferfv)
"_alGetBufferi", referenced from:
_wine_alGetBufferi in openal.o
(maybe you meant: _wine_alGetBufferi, _wine_alGetBufferiv )
"_alGetBufferiv", referenced from:
_wine_alGetBufferiv in openal.o
(maybe you meant: _wine_alGetBufferiv)
"_alGetDouble", referenced from:
_wine_alGetDouble in openal.o
(maybe you meant: _wine_alGetDoublev, _wine_alGetDouble )
"_alGetDoublev", referenced from:
_wine_alGetDoublev in openal.o
(maybe you meant: _wine_alGetDoublev)
"_alGetEnumValue", referenced from:
_wine_alGetEnumValue in openal.o
(maybe you meant: _wine_alGetEnumValue)
"_alGetError", referenced from:
_wine_alGetError in openal.o
(maybe you meant: _wine_alGetError)
"_alGetFloat", referenced from:
_wine_alGetFloat in openal.o
(maybe you meant: _wine_alGetFloat, _wine_alGetFloatv )
"_alGetFloatv", referenced from:
_wine_alGetFloatv in openal.o
(maybe you meant: _wine_alGetFloatv)
"_alGetInteger", referenced from:
_wine_alGetInteger in openal.o
(maybe you meant: _wine_alGetInteger, _wine_alGetIntegerv )
"_alGetIntegerv", referenced from:
_wine_alGetIntegerv in openal.o
(maybe you meant: _wine_alGetIntegerv)
"_alGetListener3f", referenced from:
_wine_alGetListener3f in openal.o
(maybe you meant: _wine_alGetListener3f)
"_alGetListener3i", referenced from:
_wine_alGetListener3i in openal.o
(maybe you meant: _wine_alGetListener3i)
"_alGetListenerf", referenced from:
_wine_alGetListenerf in openal.o
(maybe you meant: _wine_alGetListenerfv, _wine_alGetListenerf )
"_alGetListenerfv", referenced from:
_wine_alGetListenerfv in openal.o
(maybe you meant: _wine_alGetListenerfv)
"_alGetListeneri", referenced from:
_wine_alGetListeneri in openal.o
(maybe you meant: _wine_alGetListeneriv, _wine_alGetListeneri )
"_alGetListeneriv", referenced from:
_wine_alGetListeneriv in openal.o
(maybe you meant: _wine_alGetListeneriv)
"_alGetProcAddress", referenced from:
_LoadProcs in openal.o
_wine_alGetProcAddress in openal.o
(maybe you meant: _wine_alGetProcAddress)
"_alGetSource3f", referenced from:
_wine_alGetSource3f in openal.o
(maybe you meant: _wine_alGetSource3f)
"_alGetSource3i", referenced from:
_wine_alGetSource3i in openal.o
(maybe you meant: _wine_alGetSource3i)
"_alGetSourcef", referenced from:
_wine_alGetSourcef in openal.o
(maybe you meant: _wine_alGetSourcef, _wine_alGetSourcefv )
"_alGetSourcefv", referenced from:
_wine_alGetSourcefv in openal.o
(maybe you meant: _wine_alGetSourcefv)
"_alGetSourcei", referenced from:
_wine_alGetSourcei in openal.o
(maybe you meant: _wine_alGetSourceiv, _wine_alGetSourcei )
"_alGetSourceiv", referenced from:
_wine_alGetSourceiv in openal.o
(maybe you meant: _wine_alGetSourceiv)
"_alGetString", referenced from:
_wine_alGetString in openal.o
(maybe you meant: _wine_alGetString)
"_alIsBuffer", referenced from:
_wine_alIsBuffer in openal.o
(maybe you meant: _wine_alIsBuffer)
"_alIsEnabled", referenced from:
_wine_alIsEnabled in openal.o
(maybe you meant: _wine_alIsEnabled)
"_alIsExtensionPresent", referenced from:
_wine_alIsExtensionPresent in openal.o
(maybe you meant: _wine_alIsExtensionPresent)
"_alIsSource", referenced from:
_wine_alIsSource in openal.o
(maybe you meant: _wine_alIsSource)
"_alListener3f", referenced from:
_wine_alListener3f in openal.o
(maybe you meant: _wine_alListener3f)
"_alListener3i", referenced from:
_wine_alListener3i in openal.o
(maybe you meant: _wine_alListener3i)
"_alListenerf", referenced from:
_wine_alListenerf in openal.o
(maybe you meant: _wine_alListenerf, _wine_alListenerfv )
"_alListenerfv", referenced from:
_wine_alListenerfv in openal.o
(maybe you meant: _wine_alListenerfv)
"_alListeneri", referenced from:
_wine_alListeneri in openal.o
(maybe you meant: _wine_alListeneri, _wine_alListeneriv )
"_alListeneriv", referenced from:
_wine_alListeneriv in openal.o
(maybe you meant: _wine_alListeneriv)
"_alSource3f", referenced from:
_wine_alSource3f in openal.o
(maybe you meant: _wine_alSource3f)
"_alSource3i", referenced from:
_wine_alSource3i in openal.o
(maybe you meant: _wine_alSource3i)
"_alSourcePause", referenced from:
_wine_alSourcePause in openal.o
(maybe you meant: _wine_alSourcePause, _wine_alSourcePausev )
"_alSourcePausev", referenced from:
_wine_alSourcePausev in openal.o
(maybe you meant: _wine_alSourcePausev)
"_alSourcePlay", referenced from:
_wine_alSourcePlay in openal.o
(maybe you meant: _wine_alSourcePlay, _wine_alSourcePlayv )
"_alSourcePlayv", referenced from:
_wine_alSourcePlayv in openal.o
(maybe you meant: _wine_alSourcePlayv)
"_alSourceQueueBuffers", referenced from:
_wine_alSourceQueueBuffers in openal.o
(maybe you meant: _wine_alSourceQueueBuffers)
"_alSourceRewind", referenced from:
_wine_alSourceRewind in openal.o
(maybe you meant: _wine_alSourceRewind, _wine_alSourceRewindv )
"_alSourceRewindv", referenced from:
_wine_alSourceRewindv in openal.o
(maybe you meant: _wine_alSourceRewindv)
"_alSourceStop", referenced from:
_wine_alSourceStop in openal.o
(maybe you meant: _wine_alSourceStopv, _wine_alSourceStop )
"_alSourceStopv", referenced from:
_wine_alSourceStopv in openal.o
(maybe you meant: _wine_alSourceStopv)
"_alSourceUnqueueBuffers", referenced from:
_wine_alSourceUnqueueBuffers in openal.o
(maybe you meant: _wine_alSourceUnqueueBuffers)
"_alSourcef", referenced from:
_wine_alSourcef in openal.o
(maybe you meant: _wine_alSourcefv, _wine_alSourcef )
"_alSourcefv", referenced from:
_wine_alSourcefv in openal.o
(maybe you meant: _wine_alSourcefv)
"_alSourcei", referenced from:
_wine_alSourcei in openal.o
(maybe you meant: _wine_alSourceiv, _wine_alSourcei )
"_alSourceiv", referenced from:
_wine_alSourceiv in openal.o
(maybe you meant: _wine_alSourceiv)
"_alSpeedOfSound", referenced from:
_wine_alSpeedOfSound in openal.o
(maybe you meant: _wine_alSpeedOfSound)
"_alcCaptureCloseDevice", referenced from:
_wine_alcCaptureCloseDevice in openal.o
(maybe you meant: _wine_alcCaptureCloseDevice)
"_alcCaptureOpenDevice", referenced from:
_wine_alcCaptureOpenDevice in openal.o
(maybe you meant: _wine_alcCaptureOpenDevice)
"_alcCaptureSamples", referenced from:
_wine_alcCaptureSamples in openal.o
(maybe you meant: _wine_alcCaptureSamples)
"_alcCaptureStart", referenced from:
_wine_alcCaptureStart in openal.o
(maybe you meant: _wine_alcCaptureStart)
"_alcCaptureStop", referenced from:
_wine_alcCaptureStop in openal.o
(maybe you meant: _wine_alcCaptureStop)
"_alcCloseDevice", referenced from:
_wine_alcCloseDevice in openal.o
(maybe you meant: _wine_alcCloseDevice)
"_alcCreateContext", referenced from:
_wine_alcCreateContext in openal.o
(maybe you meant: _wine_alcCreateContext)
"_alcDestroyContext", referenced from:
_wine_alcDestroyContext in openal.o
(maybe you meant: _wine_alcDestroyContext)
"_alcGetContextsDevice", referenced from:
_wine_alcGetContextsDevice in openal.o
(maybe you meant: _wine_alcGetContextsDevice)
"_alcGetCurrentContext", referenced from:
_wine_alcGetCurrentContext in openal.o
(maybe you meant: _wine_alcGetCurrentContext)
"_alcGetEnumValue", referenced from:
_wine_alcGetEnumValue in openal.o
(maybe you meant: _wine_alcGetEnumValue)
"_alcGetError", referenced from:
_wine_alcGetError in openal.o
(maybe you meant: _wine_alcGetError)
"_alcGetIntegerv", referenced from:
_wine_alcGetIntegerv in openal.o
(maybe you meant: _wine_alcGetIntegerv)
"_alcGetProcAddress", referenced from:
_DllMain in openal.o
_wine_alcGetProcAddress in openal.o
(maybe you meant: _wine_alcGetProcAddress)
"_alcGetString", referenced from:
_wine_alcGetString in openal.o
(maybe you meant: _wine_alcGetString)
"_alcIsExtensionPresent", referenced from:
_wine_alcIsExtensionPresent in openal.o
(maybe you meant: _wine_alcIsExtensionPresent)
"_alcMakeContextCurrent", referenced from:
_wine_alcMakeContextCurrent in openal.o
(maybe you meant: _wine_alcMakeContextCurrent)
"_alcOpenDevice", referenced from:
_wine_alcOpenDevice in openal.o
(maybe you meant: _wine_alcOpenDevice)
"_alcProcessContext", referenced from:
_wine_alcProcessContext in openal.o
(maybe you meant: _wine_alcProcessContext)
"_alcSuspendContext", referenced from:
_wine_alcSuspendContext in openal.o
(maybe you meant: _wine_alcSuspendContext)
ld: symbol(s) not found for architecture i386
collect2: ld returned 1 exit status
winegcc: gcc failed
make[1]: *** [openal32.dll.so] Error 2
make: *** [dlls/openal32] Error 2
macs-iMac:wine-1.4.1 mac$
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Re: Question on problems with compile/make on OSX 10.7.5
Currently repeating configure/make with --disable-win16 included.
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Re: Question on problems with compile/make on OSX 10.7.5
Got a faster configure and make but identical failure at the end of the process.
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Re: Question on problems with compile/make on OSX 10.7.5
I solved the compile problem with help from a post by Charles Davis (Chip) here: http://forum.winehq.org/viewtopic.php?t=7967. Loosely quoted:
"maybe Wine is getting built for the wrong architecture. What does running:
file /Library/Frameworks/OpenAL.framework/OpenAL tell you about the OpenAL framework?
if the result is: /Library/Frameworks/OpenAL.framework/OpenAL: Mach-O dynamically linked shared library ppc"
then configure/make is picking up this first and this is PPC PowerPC which is not what I need to configure/make Intel.
I renamed this file (temporarily) for the configure/make duration so it would be skipped like so:
sudo mv /Library/Frameworks/OpenAL.framework /Library/Frameworks/OpenAL.framework.RenamedPPC
That fixed the make errors : ).
From there I started $ ./wine winecfg - which raised a few errors itself. From here I have an additional problem to solve:
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
Wine cannot find the FreeType font library. To enable Wine to use TrueType fonts please install a version of FreeType greater than or equal to 2.0.5. http://www.freetype.org
err:x11drv:process_attach failed to load libX11.6.dylib: dlopen(libX11.6.dylib, 266): image not found
err:x11drv:process_attach failed to load libX11.6.dylib: dlopen(libX11.6.dylib, 266): image not found
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
With any luck this last part should be easier to solve. I will check the situation with this FreeType library.
"maybe Wine is getting built for the wrong architecture. What does running:
file /Library/Frameworks/OpenAL.framework/OpenAL tell you about the OpenAL framework?
if the result is: /Library/Frameworks/OpenAL.framework/OpenAL: Mach-O dynamically linked shared library ppc"
then configure/make is picking up this first and this is PPC PowerPC which is not what I need to configure/make Intel.
I renamed this file (temporarily) for the configure/make duration so it would be skipped like so:
sudo mv /Library/Frameworks/OpenAL.framework /Library/Frameworks/OpenAL.framework.RenamedPPC
That fixed the make errors : ).
From there I started $ ./wine winecfg - which raised a few errors itself. From here I have an additional problem to solve:
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
Wine cannot find the FreeType font library. To enable Wine to use TrueType fonts please install a version of FreeType greater than or equal to 2.0.5. http://www.freetype.org
err:x11drv:process_attach failed to load libX11.6.dylib: dlopen(libX11.6.dylib, 266): image not found
err:x11drv:process_attach failed to load libX11.6.dylib: dlopen(libX11.6.dylib, 266): image not found
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
With any luck this last part should be easier to solve. I will check the situation with this FreeType library.
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Re: Question on problems with compile/make on OSX 10.7.5
I may have solved the freetype issue by starting with a specified path in the environment:
$ DYLD_FALLBACK_LIBRARY_PATH="/usr/X11/lib:/usr/lib" ./wine winecfg
but after I execute I'm left with the exception and no action:
$ DYLD_FALLBACK_LIBRARY_PATH="/usr/X11/lib:/usr/lib" ./wine winecfg
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
Any pointers or suggestions gratefully accepted.
$ DYLD_FALLBACK_LIBRARY_PATH="/usr/X11/lib:/usr/lib" ./wine winecfg
but after I execute I'm left with the exception and no action:
$ DYLD_FALLBACK_LIBRARY_PATH="/usr/X11/lib:/usr/lib" ./wine winecfg
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc616be
Any pointers or suggestions gratefully accepted.
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Re: Question on problems with compile/make on OSX 10.7.5
I read a few comments here and there indicating this could be a problem with Apple's X11 libraries supplied for my operating system. Later on I may get to installing Quartz. Quartz is used by Apple in versions of OSX later than mine anyway so I am happy to make that change. I will hope not break anything.
If that does not do it I may try including at least a few of the libraries config reports missing. The docs indicate they are not needed for minimal operation but it is not clear to me if winecfg may expect more than that.
I will also try to understand if the correct architecture is now used as expected for the problem I had earlier or if there is now a similar problem.
It is sad there is no Wine OSX binary distribution associated with the project. There are some 3rd party OSX Wine binary distributions (bottler etc) but I do not understand why these do not contribute to the parent project.
Any comments or pointers in any direction appreciated.
If that does not do it I may try including at least a few of the libraries config reports missing. The docs indicate they are not needed for minimal operation but it is not clear to me if winecfg may expect more than that.
I will also try to understand if the correct architecture is now used as expected for the problem I had earlier or if there is now a similar problem.
It is sad there is no Wine OSX binary distribution associated with the project. There are some 3rd party OSX Wine binary distributions (bottler etc) but I do not understand why these do not contribute to the parent project.
Any comments or pointers in any direction appreciated.
Re: Question on problems with compile/make on OSX 10.7.5
There are certain things people consider important on a Mac that doesn't come into play on Linux. To make Wine more Mac-like... some things have to be broken of the "vision" of Wine. Also its very difficult if not impossible to to good work on OSX using pure ANSI C... and I think its rather stupid that Wine requires that, so I have no intention of trying to get code working to contribute to Wine like that specific for Macs... I'd rather use Wine as-is and write my own tools to use it easier, which are outside of the scope of Wine. Added to that, I don't like using a layer like Wine/Crossover to run apps in all the time, I like to hide all that behind the scenes and make ported apps that are fully self contained with Wine and such inside them to they look and feel like normal Mac apps as much as possible, and people can take and run them without having to install Wine and such which can be a real pain.... this is why I started up Wineskin. I don't see any way to add that type of stuff to the Wine project. Could I make some type Wine build that people could just download and install then have normal command line running Wine just like they had built it at Macports? Sure... that is actually very easy, but I do not get the point in doing that when people can just build their own... its all command line usage anyways with no GUI integration, so you need to know how to use the command line anyways. I actually added a way in Wineskin wrappers to launch up a command line using the Wine version from the engine in that wrapper and its all normal command line Wine usage, just using the pre-built Wine version. Its more for testing and less for day to day use.OSXManpage wrote: It is sad there is no Wine OSX binary distribution associated with the project. There are some 3rd party OSX Wine binary distributions (bottler etc) but I do not understand why these do not contribute to the parent project
This all might change when Codeweavers starts getting their Mac driver in normal Wine and the extra X11 layer isn't needed any more. I've played around with it some, and while I still consider it an Alpha, its a step in the right direction, but it doesn't appear they've added it to normal Wine yet. It will be easier to do some OS GUI integration and may be worth building a prebuilt binary.
-
- Level 1
- Posts: 8
- Joined: Tue Dec 18, 2012 9:46 pm
Re: Question on problems with compile/make on OSX 10.7.5
Thank you for your thoughts on that doh123. I have had good results with Wineskin. I think I will return to that.
Can you tell me where is the most active forum for Wineskin discussion/configuration?
Can you tell me where is the most active forum for Wineskin discussion/configuration?
Re: Question on problems with compile/make on OSX 10.7.5
The most active I know of would be the forums over at Portingteam.comOSXManpage wrote:Thank you for your thoughts on that doh123. I have had good results with Wineskin. I think I will return to that.
Can you tell me where is the most active forum for Wineskin discussion/configuration?
Re: Question on problems with compile/make on OSX 10.7.5
after my little rant above about pure ANSI C... it appears someone finally caved and ObjC is being allowed as of Wine 1.5.21 for the Mac Driver that Codeweavers has been working on... nice! (I'm sure I had nothing to do with it). If I find the time and get bored I might work on it some... whenever/if Codeweavers adds it to normal Wine. Right now I've played with it some from Crossover Wine source... and it has promise.
Re: Question on problems with compile/make on OSX 10.7.5
Apple removed the gcc compiler in newer versions of OSX, so you won't be able to get it to compile. They have a Clang compile that pretends to be gcc, but won't compile wine. Some guys are working to make the Wine code compile with Clang, but it's not working on OS X currently.
I would recommend trying the http://code.google.com/p/osxwinebuilder/ bash script, which compiles gcc and then uses it to build wine. It includes a ton of other libraries that are not needed in most cases. Of course those could just be commented out...
I would recommend trying the http://code.google.com/p/osxwinebuilder/ bash script, which compiles gcc and then uses it to build wine. It includes a ton of other libraries that are not needed in most cases. Of course those could just be commented out...