Fixing FIXME in uxtheme

[Wszdexdrf]

Hello everyone.

While running a few windows programs using wine, I often encountered the message

Code: Select all

fixme:uxtheme:DrawThemeTextEx unsupported flags 0x%08lx

After looking into it, I found the exact place in dlls/uxtheme/draw.c. I wanted to fix this issue, if possible, by myself. Since this will be my first contribution to wine, could you please point out any relevant resources specific to this FIXME I need to consider before submitting patches? Also, do let me know what is the proper procedure of submitting patches for review. I want to be of some help.

Thank you.

[DarkShadow44]

Is there an actual issue with running those programs? Otherwise there isn't really a need to fix that FIXME.

[Wszdexdrf]

Hi,
The difference between running that application on Windows directly and via wine is nothing other than minor visual differences (which might even be unrelated). I just encountered the FIXME and wanted to fix it as it was seemingly easy. Anyway, I would like to contribute to wine by solving some issues, preferably something simple as a starting point. Could you point towards some issues/bugs which need patching, so I could help. I have read the wiki articles Submitting_Patches and Git_Wine_Tutorial.

[DarkShadow44]

EDIT: Wrong post, here the correct one:

IMHO just fixing a FIXME without any visible effect isn't useful.
A few issues I think are easy:

• L.A. Noire with V-Patch needs dinput8.GetdfDIJoystick
• Notepad++: save as dialog should auto-select text
• Windows Sysinternals ProcessExplorer v12.x-v16.21 crashes due to missing advapi32.I_QueryTagInformation() stub
• Multiple apps (Vavoo Webinstaller,Kodi) fail with windows version set to Win7: wmic.exe needs support for "/?" switch
• NVIDIA GeForceNow Installer fails due to rundll32 problems
• UI: Application using ModernWPF crashes, Windows.UI.ViewManagement.UISettings not implemented

Of course not all of them might actually be easy, or easy for you.
IMHO simple missing functions/com interfaces are the easiest, then some crashes, then the rest.
Feel free to pick any bug you think might be easy, or ask on IRC