I want to contribute code for wine and become a developer.

Open forum for end-user questions about Wine. Before asking questions, check out the Wiki as a first step.
Forum Rules
Locked
yaocong
Level 2
Level 2
Posts: 19
Joined: Fri Mar 04, 2011 10:20 pm
Location: China
Contact:

I want to contribute code for wine and become a developer.

Post by yaocong » Thu Sep 01, 2011 10:10 pm

I am porting wine to MIPS and do some job in winebuild/ntdll/ etc.
I am using qemu to translate x86 instruction and direct the win32 api call from the qemu to wine in MIPS version.

Wine on mips is running now! I want to contribute the modification to wine .
How can I do that?

User avatar
DanKegel
Moderator
Moderator
Posts: 1164
Joined: Wed May 14, 2008 11:44 am

Post by DanKegel » Thu Sep 01, 2011 11:41 pm

Sounds like a big job.

You could start by forking wine's github repo, see
http://wiki.winehq.org/GitWine#head-0e6 ... e623462a9e
checking in your changes to that,
and posting the URL on the wine-devel mailing list,
inviting people to look at your code.

Are all the changes your own, and are you releasing them under
the LGPL?

yaocong
Level 2
Level 2
Posts: 19
Joined: Fri Mar 04, 2011 10:20 pm
Location: China
Contact:

Post by yaocong » Fri Sep 02, 2011 2:46 am

Administrator@PC-201108231454 /d/open_source
$ git clone git@github.com:yaosihai/wine.git mywine
Cloning into mywine...
Permission denied (publickey).
fatal: The remote end hung up unexpectedly

uhm....

User avatar
DanKegel
Moderator
Moderator
Posts: 1164
Joined: Wed May 14, 2008 11:44 am

Post by DanKegel » Fri Sep 02, 2011 9:00 am

On second thought: I see you only recently started (as in, last week).
Maybe it would suffice for you to follow the normal wine developer route,
see http://wiki.winehq.org/Developers

github is really for contributors that have already gotten up to speed
and are making lots of changes (imho).

yaocong
Level 2
Level 2
Posts: 19
Joined: Fri Mar 04, 2011 10:20 pm
Location: China
Contact:

Post by yaocong » Fri Sep 02, 2011 10:52 pm

I am confused by so many link on the pages.
Is there any simple way to contribute the code for wine?
Wine on MIPS is running very smooth and I have added a lot of code in NTDLL/winebuild/wingcc . I want to share with you.
Or I just upload the the zipped package ?

Frédéric Delanoy

I want to contribute code for wine and become a developer.

Post by Frédéric Delanoy » Sat Sep 03, 2011 5:15 am

On Sat, Sep 3, 2011 at 05:52, yaocong <wineforum-user@winehq.org> wrote:
I am confused by so many link on the pages.
Is there any simple way to contribute the code for wine?
Wine on MIPS is running very smooth and I have added a lot of code in NTDLL/winebuild/wingcc . I want to share with you.
I suggest you skim through/read in the following order:
http://wiki.winehq.org/DeveloperFaq
http://wiki.winehq.org/Developers-Hints
Maybe http://wiki.winehq.org/HackingTips
http://wiki.winehq.org/GitWine

and perhaps more importantly http://wiki.winehq.org/SubmittingPatches
Or I just upload the the zipped package ?
Submitting a big blob is a sure way to get it ignored.

User avatar
dimesio
Moderator
Moderator
Posts: 12674
Joined: Tue Mar 25, 2008 10:30 pm

Post by dimesio » Sat Sep 03, 2011 6:13 am

yaocong wrote:I am confused by so many link on the pages.
Is there any simple way to contribute the code for wine?
Wine on MIPS is running very smooth and I have added a lot of code in NTDLL/winebuild/wingcc . I want to share with you.
Or I just upload the the zipped package ?
You're asking in the wrong place. This is the user's forum. Questions about submitting patches should be directed to the developer's mailing list.

User avatar
André H.
Moderator
Moderator
Posts: 202
Joined: Sun Dec 07, 2008 8:33 am
Location: Germany
Contact:

Post by André H. » Sat Sep 03, 2011 7:23 am

yaocong wrote:I am confused by so many link on the pages.
Is there any simple way to contribute the code for wine?
Wine on MIPS is running very smooth and I have added a lot of code in NTDLL/winebuild/wingcc . I want to share with you.
Or I just upload the the zipped package ?
It seems to me that your OS (FA) is already using a modified version of Wine, so you have to plublish your changes anyway. you can first start with uploading your patches somewhere, then splitting them by module(winegcc/...) is the first consequence.

Then they should be in a state like my ARM patches were:
http://source.winehq.org/git/wine.git/c ... 07a1265b5e
http://source.winehq.org/git/wine.git/c ... 33e087e155

User avatar
André H.
Moderator
Moderator
Posts: 202
Joined: Sun Dec 07, 2008 8:33 am
Location: Germany
Contact:

Post by André H. » Mon Sep 26, 2011 12:21 pm

yaocong:
Didn't hear from you again.
If you could at least upload your code somewhere or send it per e-mail to wine-devel@winehq.org so we can review it and tell you what you need to get it into wine would be a good first step.
I hope to hear from you. Best regards.

yaocong
Level 2
Level 2
Posts: 19
Joined: Fri Mar 04, 2011 10:20 pm
Location: China
Contact:

Post by yaocong » Tue Sep 27, 2011 8:01 pm

hi,
I am testing the mips wine on many machine, and find a bug! So I am trying to fix it now. So be patient,and I need to learn how to use git because I am always using SVN.

User avatar
André H.
Moderator
Moderator
Posts: 202
Joined: Sun Dec 07, 2008 8:33 am
Location: Germany
Contact:

Post by André H. » Wed Mar 28, 2012 1:05 pm

yaocong:
It has been some time now. I hope you're still interested to get that back into wine. A first step would be to upload a zipped package with the patches somewhere as you suggested before. then we can see what needs to be done and instruct you in git.
It's not time consuming, so you don't need to be afraid ;)

Thx in advance

Locked