some code removed:(

gaal.nix.rulez · Post by **gaal.nix.rulez** » Sat Apr 11, 2009 2:26 am

http://winehq.org/announce/1.1.19

wined3d: Remove some code that doesn't make a whole lot of sense.

Why? Wine is used for old programs too. Now they won't work. Are you happy?

austin987 · Post by **austin987** » Sat Apr 11, 2009 2:35 am

On Sat, Apr 11, 2009 at 2:26 AM, gaal.nix.rulez
<[email protected]> wrote:

http://winehq.org/announce/1.1.19

wined3d: Remove some code that doesn't make a whole lot of sense.

Why? Wine is used for old programs too. Now they won't work. Are you happy?

Did it break your program? File a bug. Be sure to run a regression test first:
http://wiki.winehq.org/RegressionTesting

so you know what patch broke it (there's been _a lot_ of cleanup lately).

--
-Austin

Warren Dumortier · Post by **Warren Dumortier** » Sat Apr 11, 2009 6:13 am

2009/4/11 Austin English <[email protected]>:

On Sat, Apr 11, 2009 at 2:26 AM, gaal.nix.rulez
<[email protected]> wrote:
http://winehq.org/announce/1.1.19

wined3d: Remove some code that doesn't make a whole lot of sense.

Why? Wine is used for old programs too. Now they won't work. Are you happy?
Did it break your program? File a bug. Be sure to run a regression test first:
http://wiki.winehq.org/RegressionTesting

so you know what patch broke it (there's been _a lot_ of cleanup lately).

--
-Austin

It doesn't say "Remove deprecated code"...
Dunno what the patch is, but it's probably a clean-up patch...

msclrhd · Post by **msclrhd** » Sat Apr 11, 2009 6:33 am

From the patch in question (http://archives.free.net.ph/message/200 ... pt-BR.html):

The "instr" parameter to shader_glsl_gen_modifier() is actually a source
parameter, so comparing against WINED3DSIO_TEXKILL is just silly.

What was removed was a single if...return check, which according to the information above makes sense. If it didn't make sense, the other Wine/CodeWeavers DirectX developers would have commented on it.

There are various checks to make sure that a patch is correct: reviews of patches sent to the mailing list; Alexandre (the ultimate reviewer and applier of patches) and conformance tests. This system is not perfect, and regressions do happen (the Windows API is very big and complex).

James McKenzie · Post by **James McKenzie** » Sat Apr 11, 2009 10:51 am

Warren Dumortier wrote:

2009/4/11 Austin English <[email protected]>:

On Sat, Apr 11, 2009 at 2:26 AM, gaal.nix.rulez
<[email protected]> wrote:

http://winehq.org/announce/1.1.19

wined3d: Remove some code that doesn't make a whole lot of sense.

Why? Wine is used for old programs too. Now they won't work. Are you happy?

Did it break your program? File a bug. Be sure to run a regression test first:
http://wiki.winehq.org/RegressionTesting

so you know what patch broke it (there's been _a lot_ of cleanup lately).

--
-Austin

It doesn't say "Remove deprecated code"...
Dunno what the patch is, but it's probably a clean-up patch...

I would go along with the regression test, which may be as simple as
running under 1.1.18 and then under 1.1.19. However, you did not
mention the name of the program that broke, please do.

Thank you.

James McKenzie

Daemon · Post by **Daemon** » Sat Apr 11, 2009 11:54 am

gaal.nix.rulez wrote: Now they won't work.

What are 'they'....?

DaVince · Post by **DaVince** » Sun Apr 12, 2009 10:41 am

gaal.nix.rulez wrote:http://winehq.org/announce/1.1.19

wined3d: Remove some code that doesn't make a whole lot of sense.

Why? Wine is used for old programs too. Now they won't work. Are you happy?

How many old/16 bit programs use D3D?

Don't randomly blame one of the patches, all of them aim at improving Wine in some way or another after all, but regressions do happen with some of them. You just never really know with which ones or what the cause is unless you're the developer of those patches and have access to the apps that don't work. But in that case you'd fix it before submitting the patch, obviously.