What does "fixing tests failures" mean for users?

Fazer · Post by **Fazer** » Fri Nov 07, 2008 10:41 am

I noticed there are lots of "fixing tests failures" commits in Wine git and they made me curious. How do a normal user benefit from them? What do those tests do? Why is it so important to make them work?

jeffz · Post by **jeffz** » Fri Nov 07, 2008 1:20 pm

Fazer wrote:I noticed there are lots of "fixing tests failures" commits in Wine git and they made me curious. How do a normal user benefit from them? What do those tests do? Why is it so important to make them work?

Tests prove the correctness of code. Generally, when working out a bug or implementation you write a test that passes on Windows and then work on Wine until the test passes there and cause no additional failures. Higher test coverage prevents regressions and serves as documentation.

Daemon · Post by **Daemon** » Wed Nov 19, 2008 4:55 pm

Fazer wrote:Tests prove the correctness of code. Generally, when working out a bug or implementation you write a test that passes on Windows and then work on Wine until the test passes there and cause no additional failures. Higher test coverage prevents regressions and serves as documentation.

How would you go about *NOT* building the /Tests directories & makefiles from source? It practically doubles the compile time for no added benefit for me.

vitamin · Post by **vitamin** » Wed Nov 19, 2008 5:57 pm

Daemon wrote:How would you go about *NOT* building the /Tests directories & makefiles from source? It practically doubles the compile time for no added benefit for me.

You can't unless you modify Makefiles.

austin987 · Post by **austin987** » Wed Nov 19, 2008 6:03 pm

On Wed, Nov 19, 2008 at 3:55 PM, Daemon <[email protected]> wrote:

Fazer wrote:
Tests prove the correctness of code. Generally, when working out a bug or implementation you write a test that passes on Windows and then work on Wine until the test passes there and cause no additional failures. Higher test coverage prevents regressions and serves as documentation.
How would you go about *NOT* building the /Tests directories & makefiles from source? It practically doubles the compile time for no added benefit for me.

See the RegressionTesting wiki page. I've put a patch up that disables
building the tests.

--
-Austin

Daemon · Post by **Daemon** » Wed Nov 19, 2008 8:48 pm

austin987 wrote:

See the RegressionTesting wiki page. I've put a patch up that disables
building the tests.

--
-Austin[/quote]

Sweet. Thanks for the info.