dlls/ws2_32/socket.c missing a #ifdef in 1.7.40

Open forum for end-user questions about Wine. Before asking questions, check out the Wiki as a first step.
Forum Rules
Locked
ischou
Level 4
Level 4
Posts: 109
Joined: Sun Nov 28, 2010 7:22 pm

dlls/ws2_32/socket.c missing a #ifdef in 1.7.40

Post by ischou » Mon Apr 06, 2015 8:41 am

At around line 366:

Code: Select all

        DEBUG_SOCKLEVEL(WS_NSPROTO_IPX);
        switch(optname)
        {
            DEBUG_SOCKOPT(WS_IPX_PTYPE);
            DEBUG_SOCKOPT(WS_IPX_FILTERPTYPE);
            DEBUG_SOCKOPT(WS_IPX_DSTYPE);
            DEBUG_SOCKOPT(WS_IPX_RECVHDR);
            DEBUG_SOCKOPT(WS_IPX_MAXSIZE);
            DEBUG_SOCKOPT(WS_IPX_ADDRESS);
            DEBUG_SOCKOPT(WS_IPX_MAX_ADAPTER_NUM);
        }
        break;
All the WS_IPX_* are not defined if HAS_IPX was not defined, so should this whole block get surrounded with an ifdef HAS_IPX/endif?

Causes a clean build of 1.7.40 to fail for me.

User avatar
olivierfrdierick
Level 5
Level 5
Posts: 254
Joined: Thu Sep 13, 2012 12:09 pm
Location: Nivelles, Belgium
Contact:

Re: dlls/ws2_32/socket.c missing a #ifdef in 1.7.40

Post by olivierfrdierick » Sun Apr 12, 2015 7:53 pm

Wine devs are seldom seen on these forums.
You should file a bug report "Wine compilation fails when HAS_IPX is not defined", specifying how you did get HAS_IPX undefined and the exact make errors.
I'm sure a dev will make a patch quickly if it's as easy as adding an #ifdef.

doh123
Level 8
Level 8
Posts: 1227
Joined: Tue Jul 14, 2009 1:21 pm

Re: dlls/ws2_32/socket.c missing a #ifdef in 1.7.40

Post by doh123 » Mon Apr 13, 2015 10:43 pm

I just noticed I have this same issue…

EDIT:
I file a bug report and attached a patchfile that fixed the issue for me.
https://bugs.winehq.org/show_bug.cgi?id=38410

Locked