Question on Esync ...

[rawfox]

Hi,

is esync in wine-4.6 (staging) ?

Im playing Star Citizen ..

After 4.6 release i could enable esync for the first 2 commits on the way to 4.7.
Some output in the logs admit its working.
All the commits after that wont run the game, it hangs.

So if esync is available in 4.6 staging, why has it stopped working now ?
Atm, im on wine-4.6-233-g9b6d198a3c (Staging).
The game only works when esync is (default) off and not switched on by export

Code: Select all

WINEESYNC=1

Im short on time these days and can not do the needed regression, has anyone any idea ?!

Cheers, raw ^^

[Cybermax]

I saw there was a commit on staging recently regarding eventfd_sync... Maybe test?

https://github.com/wine-staging/wine-st ... 5e1880208a

[Bob Wya]

Hi,
...
Im short on time these days and can not do the needed regression, has anyone any idea ?!

Since Wine Staging now integrates the wine-esync patchset you'll need to do a Wine Staging regression test yourself...
Well unless you know some other Linux/Wine user that owns Star Citzen.

Personally I've found wine-esync to be pretty flaky...
Also I've not seen any performance benefits with Fallout 4 (my current "game of choice") .
So the patchset is obviously very application dependent (depending on whether wineserver is a significant bottleneck I guess)...

Bob

[rawfox]

I saw there was a commit on staging recently regarding eventfd_sync... Maybe test?

https://github.com/wine-staging/wine-st ... 5e1880208a

Nice hint, thank you, ill try that ^^

[rawfox]

Hi,
...
Im short on time these days and can not do the needed regression, has anyone any idea ?!

Since Wine Staging now integrates the wine-esync patchset you'll need to do a Wine Staging regression test yourself...
Well unless you know some other Linux/Wine user that owns Star Citzen.

Personally I've found wine-esync to be pretty flaky...
Also I've not seen any performance benefits with Fallout 4 (my current "game of choice") .
So the patchset is obviously very application dependent (depending on whether wineserver is a significant bottleneck I guess)...

Bob

Yeah, Esync is not for every and all games, but SC ran really smooth on 4.6 staging with enabled Esync ... if Esync ran at all, but a msg in the output complaining about esync can not wait for server and client and the same time, suggest its running and there may be a bug in SC not found yet.
You know, SC is still under heavy development and i would love to have it on the Linux rails ..

I often see people complaining about they prefer a native client (me as well ofc) but all this helps on the way there.

Ill check out, what Cybermax posted, maybe thats it and its from Zeb, he should have overview

[rawfox]

Yay, it was the patch Cybermax mentioned

[Bob Wya]

Nice catch guys!

Bob

[Cybermax]

This patch also breaks Battle.net launcher.

Reverting with the following patch AFTER you patched wine-staging:

Code: Select all

diff --git a/server/change.c b/server/change.c
index dd45aa9..0690227 100644
--- a/server/change.c
+++ b/server/change.c
@@ -115,7 +115,7 @@ static const struct object_ops dir_ops =
     add_queue,                /* add_queue */
     remove_queue,             /* remove_queue */
     default_fd_signaled,      /* signaled */
-    default_fd_get_esync_fd,  /* get_esync_fd */
+    NULL,                     /* get_esync_fd */
     no_satisfied,             /* satisfied */
     no_signal,                /* signal */
     dir_get_fd,               /* get_fd */

Fixes it. Or you can use:

Code: Select all

export WINEESYNC=0

In other words: Wine-staging-4.7 breaks Battle.net launcher.

[Bob Wya]

I'll revert that patch, when I finally release my Gentoo (Overlay) app-emulation/wine-staging:4.7 package...
Thanks again for the tip guys!

Bob

[Cybermax]

I'll revert that patch, when I finally release my Gentoo (Overlay) app-emulation/wine-staging:4.7 package...
Thanks again for the tip guys!

Bob

Testing a possible fix now: https://github.com/wine-staging/wine-st ... bacd9cc36f

EDIT: Yeah, seems as this patch fixed the other one

[rawfox]

Yeah this is fixed now in the current staging patches.
Seems it was a last minute patch as the staging patches have already been released.
On testing last night, StarCitizen worked better then ever before
Thank you, people, made my night ^^..

And for the lols ...
Well i managed to post this bug in DXVK issues yesterday /facepalm ..