All, As with the previous updated versions of Wine, I have reapplied my enhancements to the "loader.c" file to version 6.8 and built a custom "DLL" library file (the make process seems to create file kernelbase.dll.so as opposed to file kernelbase.dll). In the previous iterations...

Dear ChrisM, If you read through the threads in this issue, you will note that my patch was not accepted. However, I did receive an email from another contributor who has submitted his own set of patches to add resource retrieval from associated language specific resource files. Since he is a past c...

Dear DarkShadow44, If you want to work up some tests, go for it. As I said, I am quite happy with the journey and learning a bunch about C programming and also some of the internal functions in Wine. And, I have a version of Wine that allows those games to work on my Linux system. As noted in earlie...

Dear DarkShadow44, I did a bit of digging into the test source code for testing in the kernelbase and kernel32 dll's, and I basically got the "deer in the headlights" sensation. It looked overwhelming. It appeared that the tester manually constructed a "PE" format file for load t...

Dear Darkshadow44, FYI, I have good news and bad news regarding my patch submission. The good news is that the patch was finally reviewed after my repeated submissions. The bad news is that the patch was rejected. Evidently, this was due to not having any test results. As a reference, if you are cur...

Dear DarkShadow44, I noticed that the resubmission of my patch fell off the list as well. Possibly, that might have been timing as I saw that as version 6.0 was being finalized there had been a code freeze. So since I found no code changes in the "loader.c" file since my original patch sub...

Dear DarkShadow44, The patch I submitted just disappeared from the patch list without any notification of either being accepted or rejected. In reviewing the documentation about submitting patches, the documentation indicates that I should have gotten some feedback, but I did not receive any feedbac...

All, The source code changes have been applied to version 5.22 of the Wine application and tested. FYI, the patch I submitted at the beginning of the month is still in the queue. I am guessing that it is waiting on the assignment of a code reviewer. I will keep monitoring the progress through the pa...

Dear DarkShadow44, FYI, with the various refinements I have made to this enhancement within the "loader.c" file, I decided to go ahead and submit the enhancements as a patch. I will see if the folks at Codeweavers feel the enhancement has merit. From what I have found in researching the we...

All, I have done a bit of rearrangement of the code enhancements to version 5.20 of program file loader.c so that other than the static variable field additions, all of the additional code and revised code resides within the same general vicinity in the source code file. I've again tested out the en...

All, Again, with a new release of Wine (5.18), I applied the MUI enhancement to the "loader.c" file and ran the enhancement through various tests. I found that there had been some changes to the memory mapping function (or up to this point, I had just been lucky) that allowed the MUI file ...

Dear DarkShadow44, I was able to determine what test was producing the "ntdll" errors. For some reason, the testers set a boolean flag argument differently for the "ntdll.dll" test differently than the other "dll" tests. I don't know why, but when I set the boolean flag...

Dear DarkShadow44, I viewed the Wine conformance testing link which discussed running an end-to-end test of the Wine application along with how to test a specific file. Strangely, the test for the "loader.c" file was in the "kernel32/tests" folder rather than in the "kernelb...

Dear DarkShadow44, I again did some testing of the "MUI" support enhancement after downloading the latest development version of Wine (5.16) to make sure that there were no knock-on effects within the latest version. I also reviewed one of my condition tests in the "LoadResource"...

Dear DarkShadow44, I took your advice and formally performed various unit test scenarios and documented them. I searched to see if there was a specific unit test template used for the Wine application or for C programming in general and did not find anything. So, I just composed a unit test document...

Dear DarkShadow44, Your question about the test sequence for checking both the executable file and the MUI file caused me to reflect to see if I could devise a method to perform a second resource check if the initial module reference does not contain the resource. So, I went back and revised the res...

Dear DarkShadow44, To try to answer your question about the search sequence for resources, the enhancement does not search both files for any given resource. It is an either/or situation. If the resource is determined to be a resource name that was generated with the MAKEINTRESOURCE function (in oth...

Dear DarkShadow44, I also tried out your patch for the animation. At first after making the code change and running the make command, I was still not getting any animation and the checkbox was still grayed out. However, in reviewing the source code I realized that these values were the initial value...

DarkShadow44, Actually, when I had first attempted to locate an associated MUI file for resource retrieval, I did leave out any resource value conditioning within the LoadResource function. So I reverted to not having that condition within that function. The net result of that is any resource locate...

Dear DarkShadow44, I am not sure if you are monitoring this issue anymore, but if you are, I do have question regarding animation functionality within the Mahjong Titans game and some of the other games in this set (such as Spider Solitaire). These games contain functionality for presenting animated...

To nadeloehr, DarkShadow44, qwertynmb, and uggina, Since version 5.15 has been released, I again downloaded a copy of the source code and built an iteration of Wine for that version. I then reapplied the enhancements to file "loader.c" and tested out the enhanced application. Again, the en...

All, I finally figured out why I could not utilize the "GetUserDefaultLocaleName" function within the new "GetMUI" function in the revised "loader.c" program. It turns out that function "GetUserDefaultLocaleName" makes a call to function "FindResourceExW&...

All, Having time to do some more testing of the "loader.c" program file, I was able to refine the MUI check test in the "FindResourceExW" function so that the language neutral resources normally stored in the executable file such as icons are found and loaded. Also, I re-position...

Hello uggina, I am not sure if you are just noting that the Mahjong Titans game is a part of a game set that includes the other games you noted or for some other reason. However, other than the internet based games, I did test the other games in the Wineaero game set and the program enhancements I a...

Dear nadeloehr, I couldn't seem to find a suitable editor to provide a good difference view for cutting and pasting, so I decided to go ahead and set up a simple repository out on GitHub and add the code there. I uploaded the unmodified code for file "loader.c", then applied my coding chan...